Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response 404 for diff/patch of a commit that not exist #15221

Merged
merged 4 commits into from
Apr 1, 2021
Merged

response 404 for diff/patch of a commit that not exist #15221

merged 4 commits into from
Apr 1, 2021

Conversation

a1012112796
Copy link
Member

fix #15217

@a1012112796
response 404 for diff/patch of a commit that not exist
166a844 
fix go-gitea#15217

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2021
@lunny lunny added backport/v1.13 and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2021
@a1012112796 a1012112796 added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2021
silverwind
silverwind reviewed Mar 31, 2021
View reviewed changes
routers/repo/commit.go Outdated Show resolved Hide resolved
@zeripath @silverwind
Update routers/repo/commit.go
b602e95 
Co-authored-by: silverwind <me@silverwind.io>
zeripath
zeripath reviewed Mar 31, 2021
View reviewed changes
routers/repo/commit.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2021
@lafriks lafriks merged commit 007fb00 into go-gitea:master Apr 1, 2021
@lafriks
Copy link
Member

lafriks commented Apr 1, 2021

Please send backports

@lafriks lafriks added this to the 1.15.0 milestone Apr 1, 2021
@a1012112796 a1012112796 deleted the diff_404 branch April 1, 2021 11:38
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Apr 1, 2021
@a1012112796 @zeripath @silverwind
response 404 for diff/patch of a commit that not exist (go-gitea#15221)
31f387d 
* response 404 for diff/patch of a commit that not exist

fix go-gitea#15217

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update routers/repo/commit.go

Co-authored-by: silverwind <me@silverwind.io>

* use ctx.NotFound()

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
@a1012112796 a1012112796 mentioned this pull request Apr 1, 2021
Merged
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Apr 1, 2021
@a1012112796 @zeripath @silverwind
response 404 for diff/patch of a commit that not exist (go-gitea#15221)
5b6861c 
* response 404 for diff/patch of a commit that not exist

fix go-gitea#15217

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update routers/repo/commit.go

Co-authored-by: silverwind <me@silverwind.io>

* use ctx.NotFound()

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
@a1012112796 a1012112796 mentioned this pull request Apr 1, 2021
Merged
@a1012112796 a1012112796 added the backport/done All backports for this PR have been created label Apr 1, 2021
techknowlogick pushed a commit that referenced this pull request Apr 1, 2021
@a1012112796 @zeripath
@silverwind @6543
response 404 for diff/patch of a commit that not exist (#15221) (#15237)
c6eb9b3 
* response 404 for diff/patch of a commit that not exist

fix #15217

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update routers/repo/commit.go

Co-authored-by: silverwind <me@silverwind.io>

* use ctx.NotFound()

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: 6543 <6543@obermui.de>
zeripath added a commit that referenced this pull request Apr 2, 2021
@a1012112796 @zeripath
@silverwind @6543
response 404 for diff/patch of a commit that not exist (#15221) (#15238)
0d7afb0 
* response 404 for diff/patch of a commit that not exist

fix #15217

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update routers/repo/commit.go

Co-authored-by: silverwind <me@silverwind.io>

* use ctx.NotFound()

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@silverwind silverwind silverwind left review comments

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

HTTP 500 when trying to download diff/patch of a commit that doesn't exist
6 participants
@a1012112796 @lafriks @lunny @silverwind @zeripath @GiteaBot